From 29a694263f5ed91379d24439054a74514b6b1227 Mon Sep 17 00:00:00 2001
From: Thomas Rientjes <synzvato@protonmail.com>
Date: Fri, 29 Jun 2018 10:24:09 +0200
Subject: [PATCH] Refactor existing codebase
---
core/constants.js | 2 ++
core/file-guard.js | 4 ++--
core/state-manager.js | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/core/constants.js b/core/constants.js
index 8bbb069..5bbc13e 100644
--- a/core/constants.js
+++ b/core/constants.js
@@ -27,6 +27,8 @@ const Address = {
'EXAMPLE': 'example.org',
'HTTP': 'http:',
'HTTPS': 'https:',
+ 'RESOURCE_PATH': '/resources',
+ 'ROOT_PATH': '/',
'WWW_PREFIX': 'www.'
};
diff --git a/core/file-guard.js b/core/file-guard.js
index 6f5e696..fc71543 100644
--- a/core/file-guard.js
+++ b/core/file-guard.js
@@ -39,7 +39,7 @@ fileGuard._startListening = function () {
fileGuard._verifyRequest = function (requestDetails) {
- let redirectUrl = chrome.runtime.getURL('/');
+ let redirectUrl = chrome.runtime.getURL(Address.ROOT_PATH);
if (!requestDetails.url.endsWith(fileGuard.secret)) {
return {redirectUrl};
@@ -50,7 +50,7 @@ fileGuard._verifyRequest = function (requestDetails) {
* Initializations
*/
-fileGuard.path = chrome.runtime.getURL('/resources');
+fileGuard.path = chrome.runtime.getURL(Address.RESOURCE_PATH);
fileGuard.secret = '';
if (fileGuard.path.startsWith(Address.CHROME_EXTENSION)) {
diff --git a/core/state-manager.js b/core/state-manager.js
index 4430133..0620c34 100644
--- a/core/state-manager.js
+++ b/core/state-manager.js
@@ -123,7 +123,7 @@ stateManager._removeTab = function (tabIdentifier) {
stateManager._updateTab = function (details) {
- let tabDomain, domainIsWhitelisted, tabIdentifier, frameIdentifier;
+ let tabDomain, domainIsWhitelisted, frameIdentifier, tabIdentifier;
tabDomain = helpers.extractDomainFromUrl(details.url);
domainIsWhitelisted = stateManager._domainIsWhitelisted(tabDomain);
--
GitLab