From c219fae3fbd705d8e77db8a627b65762bdf98148 Mon Sep 17 00:00:00 2001 From: Thomas Rientjes <synzvato@protonmail.com> Date: Thu, 11 Jan 2018 12:07:50 -0300 Subject: [PATCH] Improve injection count formatting --- modules/internal/helpers.js | 7 +++++++ pages/popup/popup.js | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/modules/internal/helpers.js b/modules/internal/helpers.js index 54a1ed1..d44d3e5 100644 --- a/modules/internal/helpers.js +++ b/modules/internal/helpers.js @@ -201,6 +201,13 @@ helpers.determineScriptDirection = function (language) { return scriptDirection; }; +helpers.formatNumber = function (number) { + + if (typeof number === 'number') { + return number.toLocaleString(); + } +}; + helpers.formatVersion = function (version) { if (version.indexOf('beta') === -1) { diff --git a/pages/popup/popup.js b/pages/popup/popup.js index befa4ac..685ada3 100644 --- a/pages/popup/popup.js +++ b/pages/popup/popup.js @@ -47,7 +47,7 @@ popup._renderNonContextualContents = function () { optionsButtonElement = document.getElementById('options-button'); versionLabelElement.innerText = popup._version; - counterElement.innerText = popup._amountInjected; + counterElement.innerText = helpers.formatNumber(popup._amountInjected); testingUtilityLinkElement.addEventListener('mouseup', popup._onTestingUtilityLinkClicked); optionsButtonElement.addEventListener('mouseup', popup._onOptionsButtonClicked); -- GitLab