From ff4bbeaf30d8f6025209aad833b64c34674a7f8c Mon Sep 17 00:00:00 2001
From: Thomas Rientjes <synzvato@protonmail.com>
Date: Sat, 2 Sep 2017 23:30:34 -0400
Subject: [PATCH] Refactor extension options page
---
pages/options/options.css | 28 ++++++++++++++++++----------
pages/options/options.html | 10 +++++-----
pages/options/options.js | 3 +--
3 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/pages/options/options.css b/pages/options/options.css
index c0bfa82..3a9a541 100644
--- a/pages/options/options.css
+++ b/pages/options/options.css
@@ -1,17 +1,25 @@
-section {
- padding-left: 32px;
-}
+/**
+ * Titles
+ */
-section .title {
- -webkit-margin-start: -32px;
+.option-title {
font-weight: bold;
}
-section .description {
- font-style: italic;
- margin-bottom: 16px;
+/**
+ * Controls
+ */
+
+.text-input {
+ margin-left: 36px !important;
}
-.button-panel {
- text-align: right;
+/**
+ * Miscellaneous
+ */
+
+.option-description {
+ font-style: italic;
+ margin-bottom: 16px;
+ padding-left: 36px;
}
diff --git a/pages/options/options.html b/pages/options/options.html
index 8d2a30d..1b0d133 100644
--- a/pages/options/options.html
+++ b/pages/options/options.html
@@ -19,20 +19,20 @@
<section>
- <label class="title">
+ <label class="option-title">
<input data-option="blockMissing" type="checkbox">
<span data-i18n-content="blockMissingTitle"></span>
</label>
- <div class="description" data-i18n-content="blockMissingDescription"></div>
+ <div class="option-description" data-i18n-content="blockMissingDescription"></div>
</section>
<section>
- <div class="title" data-i18n-content="domainWhitelistTitle"></div>
- <input data-option="domainWhitelist" type="text">
- <div class="description" data-i18n-content="domainWhitelistDescription"></div>
+ <div class="option-title" data-i18n-content="domainWhitelistTitle"></div>
+ <input class="text-input" data-option="domainWhitelist" type="text">
+ <div class="option-description" data-i18n-content="domainWhitelistDescription"></div>
</section>
diff --git a/pages/options/options.js b/pages/options/options.js
index b4ab713..22c3532 100644
--- a/pages/options/options.js
+++ b/pages/options/options.js
@@ -27,10 +27,9 @@ const VALUE_SEPARATOR = ';';
document.addEventListener('DOMContentLoaded', function () {
- let i18nElements, saveButtonElement, blockMissingElement, domainWhitelistElement;
+ let i18nElements, blockMissingElement, domainWhitelistElement;
i18nElements = document.querySelectorAll('[data-i18n-content]');
- saveButtonElement = document.getElementById('save-button');
i18nElements.forEach(function (i18nElement) {
--
GitLab